Cherry pick from "next" branch #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Client class:
setConnectionProperties()
- Rely on _fix_headers to fix the case of default headers at the time of request instead of duplicating its code
_fix_headers()
- When we addin default headers, ensure the case is correct
This is a reworking of 079976b from the `next` branch which accomplishes this differently
This is a reworking of fad02fa from the `next` branch. It removes a docstring change that moves away from PEP008
This is a from 51f5b78 from the `next` branch.
- TODO: Reuse TCP connections
- Update "Parse Content-Type" bullet
This adds new content to v2.0 about parsing Content-Type headers correctly. v2.0 came out in the past but I see the ctypeParameters dict it mentions.
This is a from 6a44c59 from the `next` branch.
We use xml.dom.minidom to de-serialize the results. This is a from 3d37343 from the `next` branch.
…headers In case the API does not supply extra_headers, self.request() will fail trying to delete the 'content-type' header from them. Including the _default_headers (always) ensures that 'content-type' is defined This is a from e1143ed from the `next` branch.
Closed
# Conflicts: # agithub/GitHub.py # agithub/base.py # agithub/test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hand review of the 18 commits in the #44
nextbranch. The commits are a combination ofmasterthrough another meansnextnextthat I've rendered into 7 new commits. Some of these have been reformulated to work with the current codebase or modified to strip out things which move us farther from PEP008We should review the functionality in this PR and if it's desired, merge it and throw away #44 and the
nextbranch.